Remove unreachable else clauses.

The `$return_var` variable in these cases is forced to `false`. See #1167.
PressForward · Sep 14, 2023 · 551de03 · 551de03
1 parent 122982b
commit 551de03
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 15 deletions.
diff --git a/Core/API/MetaCheckEndpoint.php b/Core/API/MetaCheckEndpoint.php
@@ -152,11 +152,7 @@ public function register_routes() {
 						} catch ( \DomainException $e ) {
 							$return_var = new WP_Error( 'auth_fail_ssl', __( 'SSL cannot be applied to the key.', 'pressforward' ) );
 						} catch ( \Exception $e ) {
-							if ( false === $return_var ) {
-								return new WP_Error( 'auth_fail_whoknows', __( 'Authentication failed for reasons unclear.', 'pressforward' ) );
-							} else {
-								return $return_var;
-							}
+							return new WP_Error( 'auth_fail_whoknows', __( 'Authentication failed for reasons unclear.', 'pressforward' ) );
 						}
 					},
 					'priority'            => 10,

diff --git a/Core/API/NominateThisEndpoint.php b/Core/API/NominateThisEndpoint.php
@@ -232,11 +232,7 @@ public function register_routes() {
 					} catch ( \DomainException $e ) {
 						$return_var = new WP_Error( 'auth_fail_ssl', __( 'SSL cannot be applied to the key.', 'pressforward' ) );
 					} catch ( \Exception $e ) {
-						if ( false === $return_var ) {
-							return new WP_Error( 'auth_fail_whoknows', __( 'Authentication failed for reasons unclear.', 'pressforward' ) );
-						} else {
-							return $return_var;
-						}
+						return new WP_Error( 'auth_fail_whoknows', __( 'Authentication failed for reasons unclear.', 'pressforward' ) );
 					}
 				},
 				'priority'            => 10,
@@ -288,11 +284,7 @@ public function register_routes() {
 					} catch ( \DomainException $e ) {
 						$return_var = new WP_Error( 'auth_fail_ssl', __( 'SSL cannot be applied to the key.', 'pressforward' ) );
 					} catch ( \Exception $e ) {
-						if ( false === $return_var ) {
-							return new WP_Error( 'auth_fail_whoknows', __( 'Authentication failed for reasons unclear.', 'pressforward' ) );
-						} else {
-							return $return_var;
-						}
+						return new WP_Error( 'auth_fail_whoknows', __( 'Authentication failed for reasons unclear.', 'pressforward' ) );
 					}
 					return $return_var;
 				},