Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI v2] feat: Updates automation action step to support multiple actions #16681

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[UI v2] feat: Updates automation action step to support multiple actions #16681

wants to merge 1 commit into from

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Jan 10, 2025 •
edited
Loading

  1. Updates ActionStep component to ActionsStep to support multiple actions that can be appended
  2. Updates action-type-schema to support an array data structure of { actions: Array<ActionType>}
Screen.Recording.2025-01-10.at.11.13.58.AM.mov

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Jan 10, 2025
@devinvillarosa devinvillarosa marked this pull request as ready for review January 10, 2025 18:39
@devinvillarosa devinvillarosa marked this pull request as draft January 10, 2025 18:40
@devinvillarosa devinvillarosa force-pushed the action-steps branch 2 times, most recently from 09f7f97 to 5ad66d4 Compare January 10, 2025 19:13
@devinvillarosa devinvillarosa marked this pull request as ready for review January 10, 2025 19:16
devinvillarosa
devinvillarosa commented Jan 10, 2025
View reviewed changes
ui-v2/src/components/ui/combobox/comboxbox.stories.tsx
@@ -1,7 +1,6 @@
import type { Meta, StoryObj } from "@storybook/react";

import { Automation } from "@/api/automations";
import { UNASSIGNED } from "@/components/automations/automations-wizard/action-step/action-type-schemas";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing dependency from this story

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@devinvillarosa