Fix connection string handling when individual components are provided via settings #16680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desertaxle
commented
Jan 10, 2025
| @@ -417,7 +413,7 @@ def _default_database_connection_url(settings: "Settings") -> SecretStr: | |||
|
|
|||
| from sqlalchemy import URL | |||
|
|
|||
| return URL( | |||
| value = URL( | |||
There was a problem hiding this comment.
This right here is the fix
CodSpeed Performance ReportMerging #16680 will not alter performanceComparing Summary
|
cicdw
approved these changes
Jan 10, 2025
desertaxle
deleted the
fix-startup-error-on-indv-database-url-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the connection URL is set to a plain string instead of a
SecretStr, which causes serialization to fail when serializing to a JSON-compatible form. This fixes that.Closes #16657