Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(experiments): new secondary metrics view #27123

Merged
merged 4 commits into from
Dec 23, 2024
Merged

feat(experiments): new secondary metrics view #27123

merged 4 commits into from
Dec 23, 2024

Conversation

jurajmajerik
Copy link
Contributor

@jurajmajerik jurajmajerik commented Dec 22, 2024 •
edited
Loading

Changes

  1. Use the new metrics view for secondary metrics. All metrics are now visualized in the same way:

image

  1. Add the explore button, overview banner and the summary table to the Detailed results modal:
    image

How did you test this code?

👀

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 22, 2024 •
edited
Loading

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@jurajmajerik jurajmajerik requested a review from a team December 23, 2024 10:28
danielbachhuber
danielbachhuber approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good overall ✅

A few thoughts to consider:

  1. The implementation banner is missing:

CleanShot 2024-12-23 at 04 02 54@2x

CleanShot 2024-12-23 at 04 03 22@2x

  1. Putting the significance flag and "detailed results" button all of the way to the right makes it easy for them to get lost:

CleanShot 2024-12-23 at 04 04 04@2x

CleanShot 2024-12-23 at 04 05 15@2x

Is there a reason you didn't put them in the leftmost column?

  1. The funnel visualization and table data feel like they contain a lot more information:

CleanShot 2024-12-23 at 04 06 37@2x

I wonder how many users will have more than one primary metric? If they only have one, we might consider showing more information for it.

@jurajmajerik
Copy link
Contributor Author

The implementation banner is missing:
Good catch!

to the right makes it easy for them to get lost
I agree, happy to iterate on this UI more. The reason is that the leftmost colum I viewed as the "editing" column and the rightmost one as the "results" one.

If they only have one, we might consider showing more information for it.
Definitely, I think we should show the credible interval + detailed results if there is only one metric.

Added these to #27014 and merging this to keep moving. 🏃

@jurajmajerik jurajmajerik merged commit ca73fa2 into master Dec 23, 2024
101 checks passed
@jurajmajerik jurajmajerik deleted the experiment-new-secondary-metrics branch December 23, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jurajmajerik @danielbachhuber