Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework of eigen features in common #660

Merged
merged 19 commits into from
May 24, 2014
Merged

Rework of eigen features in common #660

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
26d34b9
Moved computeRoots2 implementation into hpp
VictorLamoine May 15, 2014
b081539
Moved computeRoots implementation into hpp
VictorLamoine May 15, 2014
4f116ad
Moved eigen22 implementation into hpp
VictorLamoine May 15, 2014
4b6a0f1
Moved computeCorrespondingEigenVector implementation into hpp
VictorLamoine May 15, 2014
51d145d
Moved eigen33 implementation into hpp
VictorLamoine May 15, 2014
51f2c51
Moved invert2x2 implementation into hpp
VictorLamoine May 15, 2014
0739768
Moved invert3x3SymMatrix implementation into hpp
VictorLamoine May 15, 2014
f42c9a9
Moved invert3x3Matrix implementation into hpp
VictorLamoine May 15, 2014
a8a8b95
Moved determinant3x3Matrix implementation into hpp + missing document…
VictorLamoine May 15, 2014
6d06415
Templated getEulerAngles
VictorLamoine May 15, 2014
7b8abf2
Templated getTranslationAndEulerAngles
VictorLamoine May 15, 2014
3c34b39
Inlined one of the getTransformation function
VictorLamoine May 15, 2014
a1069a3
Identation corrections in the test unit
VictorLamoine May 15, 2014
b41efb8
Added inlined transformPoint
VictorLamoine May 15, 2014
0107b80
Added inlined transformVector
VictorLamoine May 15, 2014
dafd5ae
Added transformLine + test unit
VictorLamoine May 15, 2014
7f36781
Added transformPlane + test unit
VictorLamoine May 15, 2014
5bb7b0a
Added checkCoordinateSystem + test unit
VictorLamoine May 15, 2014
2ff5b6a
Added transformBetween2CoordinateSystems + test unit
VictorLamoine May 15, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Inlined one of the getTransformation function
  • Loading branch information
@VictorLamoine
VictorLamoine committed May 22, 2014
commit 3c34b3986c92faf8bb5fddcf02ea8043c7b1773d
9 changes: 7 additions & 2 deletions common/include/pcl/common/eigen.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ namespace pcl
* \param[out] t the resulting transformation matrix
* \ingroup common
*/
template<typename Scalar> void
template <typename Scalar> void
getTransformation (Scalar x, Scalar y, Scalar z, Scalar roll, Scalar pitch, Scalar yaw,
Eigen::Transform<Scalar, 3, Eigen::Affine> &t);

Expand Down Expand Up @@ -346,7 +346,12 @@ namespace pcl
* \ingroup common
*/
inline Eigen::Affine3f
getTransformation (float x, float y, float z, float roll, float pitch, float yaw);
getTransformation (float x, float y, float z, float roll, float pitch, float yaw)
{
Eigen::Affine3f t;
getTransformation<float> (x, y, z, roll, pitch, yaw, t);
return (t);
}

/** \brief Write a matrix to an output stream
* \param[in] matrix the matrix to output
Expand Down
9 changes: 0 additions & 9 deletions common/include/pcl/common/impl/eigen.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,15 +697,6 @@ pcl::getTransformation (Scalar x, Scalar y, Scalar z,
t (3, 0) = 0; t (3, 1) = 0; t (3, 2) = 0; t (3, 3) = 1;
}

//////////////////////////////////////////////////////////////////////////////////////////
Eigen::Affine3f
pcl::getTransformation (float x, float y, float z, float roll, float pitch, float yaw)
{
Eigen::Affine3f t;
getTransformation (x, y, z, roll, pitch, yaw, t);
return (t);
}

//////////////////////////////////////////////////////////////////////////////////////////
template <typename Derived> void
pcl::saveBinary (const Eigen::MatrixBase<Derived>& matrix, std::ostream& file)
Expand Down