ply reader support crlf and lf #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, could you please format according to PCL Style guide? (Opening The changes look good. Do you plan to test on Windows, or do we need to find someone for that? |
fix formatting
|
Thanks, the formatting should be fixed now. I don't have a windows system set up to test on, it would be best if someone else could verify. |
jspricke
added a commit
that referenced
this pull request
Oct 14, 2015
ply reader support crlf and lf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1256
Added a check to split lines on \r for crlf and skip the \n character, otherwise defaults to splitting on \n.
This has been verified to work on both crlf and lf in linux, it should work on windows for both filetypes but it has not been tested yet.