Fix ValueError for empty arrays in FloatArrayItem

Fix #80
PlotPyStack · Nov 14, 2024 · 1b0579d · 1b0579d
1 parent b5d5e69
commit 1b0579d
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog #
 
+## Version 3.7.2 ##
+
+🛠️ Bug fixes:
+
+* [Issue #80](https://github.com/PlotPyStack/guidata/issues/80) - `ValueError` when trying to show/edit an empty array
+
 ## Version 3.7.1 ##
 
 ℹ️ Changes:

diff --git a/guidata/__init__.py b/guidata/__init__.py
@@ -8,7 +8,7 @@
 and application development tools for Qt.
 """
 
-__version__ = "3.7.1"
+__version__ = "3.7.2"
 
 
 # Dear (Debian, RPM, ...) package makers, please feel free to customize the

diff --git a/guidata/dataset/dataitems.py b/guidata/dataset/dataitems.py
@@ -961,7 +961,9 @@ def format_string(
         larg = self.get_prop_value("display", instance, "large", False)
         fmt = self.get_prop_value("display", instance, "format", "%s")
         unit = self.get_prop_value("display", instance, "unit", "")
-        v = func(value)
+        v: np.ndarray = func(value)
+        if v.size == 0:
+            return "= []"
         if larg:
             text = "= ["
             for flt in v[:-1]:

diff --git a/guidata/dataset/qtitemwidgets.py b/guidata/dataset/qtitemwidgets.py
@@ -1314,7 +1314,7 @@ def update(self, arr: np.ndarray) -> None:
                 maxt = ", ".join(
                     [format % real_arr[:, r].max() for r in range(arr.shape[1])]
                 )
-        except (TypeError, IndexError):
+        except (TypeError, IndexError, ValueError):
             mint, maxt = "-", "-"
         self.min_label.setText(mint)
         self.max_label.setText(maxt)

diff --git a/guidata/tests/dataset/test_all_features.py b/guidata/tests/dataset/test_all_features.py
@@ -94,6 +94,9 @@ class Parameters(gds.DataSet):
     floatarray = gds.FloatArrayItem(
         "Float array", default=np.ones((50, 5), float), format=" %.2e "
     ).set_pos(col=1)
+    floatarray2 = gds.FloatArrayItem(
+        "Empty array", default=np.array([], float)
+    ).set_pos(col=2)
     g0 = gds.BeginTabGroup("group")
     mchoice1 = gds.MultipleChoiceItem(
         "MC type 1", ["first choice", "second choice", "third choice"]