-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autodesk: Text - Add the schema for MarkupText #3259
base: dev
Are you sure you want to change the base?
Autodesk: Text - Add the schema for MarkupText #3259
Conversation
A new geometry schema MarkupText and its associated property schema ColumnLayout and ParagraphLayout were defined in pxr/usd/usdText/schema.usda. MarkupText also uses property schema TextStyle which is defined by SimpleText. Details of MarkupText and its style and layout schema were defined in the Text proposal. There is no unit tests created in this PR since tests for MarkupText would require the implementation of SimpleText (which is in another PR). We will add the unit tests in another commit after the SimpleText is merged in dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated. Only need review below the line of "// --(BEGIN CUSTOM CODE)--"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated. Only need review below the line of "// --(BEGIN CUSTOM CODE)--"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated. Only need review below the line of "// --(BEGIN CUSTOM CODE)--"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated. Only need review below the line of "// --(BEGIN CUSTOM CODE)--"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated. Do not review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script generated. Do not review.
And finally realized “comment” meant GitHub comment, not source file comment. Sorry for the noise! |
Filed as internal issue #USD-10050 |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Description of Change(s)
A new geometry schema MarkupText and its associated property schema ColumnLayout and ParagraphLayout were defined in
pxr/usd/usdText/schema.usda
. MarkupText also uses property schema TextStyle which is defined by SimpleText.Several schemas boilerplate files were generated by calling
usdGenSchema
onschema.usda
. Comment "Script generated file" is added to each usdGenSchema generated file to help the reviewer identify and ignore them.Details of MarkupText and its style and layout schema were defined in the Text proposal.
PR of the Text proposal can be accessed here. Feedback on the proposal is also appreciated.
There is no unit tests created in this PR since tests for MarkupText would require the implementation of SimpleText (which is in another PR). We will add the unit tests in this PR after the SimpleText is merged in
dev
: #3258This supersedes prior #3002.
Fixes Issue(s)