Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodesk: Text - Add the schema for MarkupText #3259

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

erikaharrison-adsk
Copy link
Contributor

Description of Change(s)

A new geometry schema MarkupText and its associated property schema ColumnLayout and ParagraphLayout were defined in pxr/usd/usdText/schema.usda. MarkupText also uses property schema TextStyle which is defined by SimpleText.

Several schemas boilerplate files were generated by calling usdGenSchema on schema.usda. Comment "Script generated file" is added to each usdGenSchema generated file to help the reviewer identify and ignore them.

Details of MarkupText and its style and layout schema were defined in the Text proposal.
PR of the Text proposal can be accessed here. Feedback on the proposal is also appreciated.

There is no unit tests created in this PR since tests for MarkupText would require the implementation of SimpleText (which is in another PR). We will add the unit tests in this PR after the SimpleText is merged in dev: #3258

This supersedes prior #3002.

Fixes Issue(s)

  • N/A
  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

A new geometry schema MarkupText and its associated property schema ColumnLayout
and ParagraphLayout were defined in pxr/usd/usdText/schema.usda. MarkupText also
uses property schema TextStyle which is defined by SimpleText.

Details of MarkupText and its style and layout schema were defined in the Text proposal.

There is no unit tests created in this PR since tests for MarkupText would require the
implementation of SimpleText (which is in another PR). We will add the unit tests in
another commit after the SimpleText is merged in dev

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated. Only need review below the line of "// --(BEGIN CUSTOM CODE)--"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated. Only need review below the line of "// --(BEGIN CUSTOM CODE)--"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated. Only need review below the line of "// --(BEGIN CUSTOM CODE)--"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated. Only need review below the line of "// --(BEGIN CUSTOM CODE)--"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated. Do not review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script generated. Do not review.

@spiffmon
Copy link
Member

spiffmon commented Aug 30, 2024 via email

@spiffmon
Copy link
Member

spiffmon commented Aug 30, 2024 via email

@spiffmon
Copy link
Member

And finally realized “comment” meant GitHub comment, not source file comment. Sorry for the noise!

@jesschimein
Copy link

Filed as internal issue #USD-10050

@jesschimein
Copy link

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants