Fix delete-abstract-non-virtual-dtor warning emitted from clang

This fixes memory leaks in usdDraco due to deleting derived class via a base class pointer. This is part of PR #1684 from @charlesfleche (Internal change: 2263942)
PixarAnimationStudios · Feb 28, 2023 · 558918b · 558918b
1 parent 7e6952f
commit 558918b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/pxr/usd/plugin/usdDraco/exportAttribute.h b/pxr/usd/plugin/usdDraco/exportAttribute.h
@@ -48,6 +48,8 @@ PXR_NAMESPACE_OPEN_SCOPE
 ///
 class UsdDracoExportAttributeInterface {
 public:
+    virtual ~UsdDracoExportAttributeInterface() = default;
+
     virtual const UsdDracoAttributeDescriptor &GetDescriptor() const = 0;
     virtual void GetFromMesh(const UsdGeomMesh &usdMesh,
                              size_t numPositions) = 0;

diff --git a/pxr/usd/plugin/usdDraco/importAttribute.h b/pxr/usd/plugin/usdDraco/importAttribute.h
@@ -47,6 +47,8 @@ PXR_NAMESPACE_OPEN_SCOPE
 ///
 class UsdDracoImportAttributeInterface {
 public:
+    virtual ~UsdDracoImportAttributeInterface() = default;
+
     virtual const UsdDracoAttributeDescriptor &GetDescriptor() const = 0;
     virtual void SetToMesh(UsdGeomMesh *usdMesh) const = 0;
     virtual void PopulateValues() = 0;