Fix empty hostname bug

The read statement will evaulate the lines[n++] expression for each line in the input wordlist that does not start with #. It will however also evaluate the expression when it reads an EOF from the stream. This means that n will equal the number of entries in lines plus one, which in turn means that when rand returns n-1 in r, the resulting line will be empty. Signed-off-by: Jonas Eriksson <zqad@acc.umu.se>
PeerRails · Sep 22, 2014 · 1ff2ba8 · 1ff2ba8
1 parent 8412bfe
commit 1ff2ba8
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/genhost b/genhost
@@ -31,6 +31,8 @@ fi
 # read the word list into memory, removing commented words
 unset lines n
 while IFS= read -r 'lines[n++]'; do :; done < <(sed '/^#/d' "$wordlist")
+# since $n gets incremented even by the EOF character, remove 1 from n
+n=$(( n - 1 ))
 
 # output the random hostname(s)
 for i in $(seq $1); do