Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update outdated reference.log for resolved warnings #3417

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

harshagr70
Copy link
Contributor

@harshagr70 harshagr70 commented Jan 22, 2025

This PR updates the reference.log file for the package "DB" to remove outdated entries related to resolved warnings. The changes ensure the codebase remains clean and up-to-date.
fixes : #2758

Details:
The following outdated warnings were removed from the reference.log file:

match_dbcols: no visible binding for global variable '.'
match_dbcols: no visible binding for global variable 'as'
Undefined global functions or variables: . as
Suggestion to add importFrom("methods", "as")

Reason for Update:
The as function is already included in the NAMESPACE file via importFrom("methods", "as"), and the issue is resolved in the current codebase. The warnings in the reference.log are no longer valid.

Verification:
Ran rcmdcheck::rcmdcheck("path/to/package") to confirm that the package builds successfully with no errors, warnings, or notes.

Impact:
This PR ensures the reference.log file reflects the current state of the code and helps maintainers and contributors avoid confusion.

@github-actions github-actions bot added the Base label Jan 22, 2025
@infotroph infotroph merged commit 6d50029 into PecanProject:develop Jan 23, 2025
15 of 23 checks passed
@harshagr70 harshagr70 deleted the GH-2758-fix-tidyverse branch January 23, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix tidyverse "no visible binding for global variable" notes
3 participants