Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Upstream] build: Use XLIFF file to provide more context to Transifex translators #511

Merged
merged 4 commits into from
Jun 30, 2023
Merged

[Upstream] build: Use XLIFF file to provide more context to Transifex translators #511

merged 4 commits into from
Jun 30, 2023

Conversation

lyricidal
Copy link

Currently, only a class name is provided to the Transifex translators as a context. Neither disambiguation parameter of the tr() function nor translator comments, being included as XML elements to *.ts translation files, are not parsed by the Transifex due to its limited support of such files.

This PR makes possible to provide all of the context details via an intermediate XLIFF translation file.

With this PR make -C src translate produces the src/qt/locale/bitcoin_en.xlf file which must be provided to the Transifex as a translation source instead of src/qt/locale/bitcoin_en.ts.

Closes #21465.

An example translatable string with additional <context> and <note> XML elements:

https://github.com/bitcoin/bitcoin/blob/35d52397e72f3ab96a7797148666b501d50b445d/src/qt/locale/bitcoin_en.xlf#L126-L132

from bitcoin/bitcoin#21694

lyricidal added 4 commits June 30, 2023 11:24
@lyricidal
build: Use XLIFF file to provide more context to Transifex translators
27c7d57 
Details: https://docs.transifex.com/formats/xliff
@lyricidal
build: Add Qt lconvert tool to depends
15b1075
@lyricidal
qt [experimental]: Add a translation comment and a disambiguation string
1957394 
The goal is to see the way the Transifex presents the added items to
translators using an intermediate XLIFF translation file.
@lyricidal
Add bitcoin_en.xlf intermediate translation file to the repo
d95ccec 
As the bitcoin_en.xlf file is created by the `make -C src translate`
command, other translation-related files are also updated.
@lyricidal lyricidal added the Upstream Upstream backports/fixes label Jun 30, 2023
@lyricidal lyricidal merged commit 50bec6b into develop Jun 30, 2023
@lyricidal lyricidal deleted the upstream-xliff branch June 30, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UserR256 UserR256 UserR256 approved these changes

@SherwinHK SherwinHK Awaiting requested review from SherwinHK

@lopeed lopeed Awaiting requested review from lopeed

@lucablighthl lucablighthl Awaiting requested review from lucablighthl

@anprdev anprdev Awaiting requested review from anprdev

@Jamesj66 Jamesj66 Awaiting requested review from Jamesj66

@apophis1329 apophis1329 Awaiting requested review from apophis1329

Assignees
No one assigned
Labels
Upstream Upstream backports/fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyricidal @UserR256