Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: PHP 8.4 has been released #3115

Merged
merged 1 commit into from
Nov 22, 2024
Merged

GH Actions: PHP 8.4 has been released #3115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
GH Actions: PHP 8.4 has been released 
* Builds against PHP 8.4 are no longer allowed to fail.
* Add _allowed to fail_ builds against PHP 8.5.

Ref: https://www.php.net/releases/8.4/en.php
  • Loading branch information
@jrfnl
jrfnl committed Nov 22, 2024
commit 7c786ca890411439aed96f22e8c4fb3cdc9ef106
24 changes: 12 additions & 12 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@ jobs:
runs-on: ubuntu-22.04
strategy:
matrix:
php: ['5.5', '7.2', '8.0', '8.1', '8.2', '8.3']
php: ['5.5', '7.2', '8.0', '8.4']
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. linting seemed to have grown out of bounds a little over time. It was meant to only lint against high/low of each supported PHP major. No need for additional runs as the tests are run against all supported PHP versions anyhow.

This bring the lint build back to the original intention.

experimental: [false]
include:
- php: '8.4'
- php: '8.5'
experimental: true

name: "Lint: PHP ${{ matrix.php }}"
Expand All @@ -75,19 +75,19 @@ jobs:
custom-cache-suffix: $(date -u "+%Y-%m")

- name: Lint against parse errors
if: ${{ matrix.php != '8.4' }}
if: ${{ matrix.php != '8.5' }}
run: composer lint -- --checkstyle | cs2pr

- name: Lint against future parse errors (PHP 8.4)
if: ${{ matrix.php == '8.4' }}
- name: Lint against future parse errors (PHP 8.5)
if: ${{ matrix.php == '8.5' }}
run: composer lint

test:
needs: ['coding-standard', 'lint']
runs-on: ubuntu-22.04
strategy:
matrix:
php: ['5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2']
php: ['5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
extensions: ['optimal', 'minimal']
coverage: [false]
experimental: [false]
Expand All @@ -101,21 +101,21 @@ jobs:
extensions: 'minimal'
coverage: true
experimental: false
- php: '8.3'
- php: '8.4'
extensions: 'optimal'
coverage: true
experimental: false
- php: '8.3'
- php: '8.4'
extensions: 'minimal'
coverage: true
experimental: false

# Experimental builds. These are allowed to fail.
- php: '8.4'
- php: '8.5'
extensions: 'optimal'
coverage: false
experimental: true
- php: '8.4'
- php: '8.5'
extensions: 'minimal'
coverage: false
experimental: true
Expand Down Expand Up @@ -166,15 +166,15 @@ jobs:
# Install dependencies and handle caching in one go.
# @link https://github.com/marketplace/actions/install-php-dependencies-with-composer
- name: Install PHP packages - normal
if: ${{ matrix.php != '8.4' }}
if: ${{ matrix.php != '8.5' }}
uses: "ramsey/composer-install@v3"
with:
composer-options: ${{ steps.set_extensions.outputs.COMPOSER_OPTIONS }}
# Bust the cache at least once a month - output format: YYYY-MM.
custom-cache-suffix: $(date -u "+%Y-%m")

- name: Install PHP packages - ignore-platform-reqs
if: ${{ matrix.php == '8.4' }}
if: ${{ matrix.php == '8.5' }}
uses: "ramsey/composer-install@v3"
with:
composer-options: --ignore-platform-reqs ${{ steps.set_extensions.outputs.COMPOSER_OPTIONS }}
Expand Down