Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: PHP 8.4 has been released #3115

Merged

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Nov 22, 2024

  • Builds against PHP 8.4 are no longer allowed to fail.
  • Add allowed to fail builds against PHP 8.5.

Ref: https://www.php.net/releases/8.4/en.php

* Builds against PHP 8.4 are no longer allowed to fail.
* Add _allowed to fail_ builds against PHP 8.5.

Ref: https://www.php.net/releases/8.4/en.php
@jrfnl
Copy link
Contributor Author

jrfnl commented Nov 22, 2024

Note: I kind of suspect the "minimal" builds will fail on PHP 8.4. If that's the case, this will be related to this issue: shivammathur/setup-php#882

php: ['5.5', '7.2', '8.0', '8.1', '8.2', '8.3']
php: ['5.5', '7.2', '8.0', '8.4']
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. linting seemed to have grown out of bounds a little over time. It was meant to only lint against high/low of each supported PHP major. No need for additional runs as the tests are run against all supported PHP versions anyhow.

This bring the lint build back to the original intention.

@jrfnl
Copy link
Contributor Author

jrfnl commented Nov 22, 2024

Cricky... okay, build passed. This is weirding me out as I just saw a failing build elsewhere and the issue seemed to be related to the use of with: extensions: mbstring for setupPHP, but this workflow is using that too... Colour me flabbergasted.

@Synchro Synchro merged commit 7e2e8d5 into PHPMailer:master Nov 22, 2024
34 checks passed
@Synchro
Copy link
Member

Synchro commented Nov 22, 2024

Thanks. I'd already made a start on this in here, and the changes are largely the same as what you've done here, but I didn't know what the next version was to be called, so I'd not dealt with that bit. I'll use your changes as it's more complete than mine.

@jrfnl jrfnl deleted the feature/ghactions-update-for-php-8.4-release branch November 22, 2024 04:14
@jrfnl
Copy link
Contributor Author

jrfnl commented Nov 22, 2024

@Synchro Great minds think alike ? ;-) (sorry, didn't see you were already working on this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants