Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make idnSupported() static #1203

Merged
merged 1 commit into from
Oct 14, 2017
Merged

Make idnSupported() static #1203

merged 1 commit into from
Oct 14, 2017

Conversation

fbonzon
Copy link
Contributor

@fbonzon fbonzon commented Oct 14, 2017

Upgrade guide and changelog say that idnSupported() is now static, but it actually isn't.

Probably this PR should wait v6.1 or other version where breaking changes are OK.

Upgrade guide and changelog say that idnSupported() is now static, but it actually isn't.

Probably this PR should wait v6.1 or other version where breaking changes are OK.
@Synchro Synchro merged commit 10341cc into PHPMailer:master Oct 14, 2017
@Synchro
Copy link
Member

Synchro commented Oct 14, 2017

How odd - I wonder if a commit got lost somewhere. I think this is safe to merge because calling a static method dynamically is permitted in PHP and does not generate any errors or warnings, and the method does not use $this, which is really the only restriction on static methods, so there's no BC break. Since it's documented that it already works that way, that it doesn't is effectively a bug that should be fixed. Anyone calling it statically, as documented, will find they no longer get errors for calling a dynamic method statically, so that makes it a transparent fix rather than a BC break. Thanks for the PR and for spotting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants