forked from signalapp/libsignal
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
node: Remove "install" script that invokes node-gyp-build
- For local development, this built the Rust library automatically when you invoked `yarn install`, whether you wanted it to or not. - For the published package, this either did nothing (if the correct prebuilds were present) or produced a weird error (if they weren't). You can't use the published package without prebuilds, so maybe this was useful, but you'd find that out pretty quickly when loading the module failed. - If you used the "link" feature to build Signal Desktop with a local checkout of libsignal, this would build the Rust library automatically when you `install`ed in the *Desktop* directory, whether you wanted it to or not. - If you pointed Signal Desktop at a local checkout by copy instead of link, this would just fail, because the Rust parts wouldn't be copied with it. Overall, it's simpler to just have this step be explicit.
- Loading branch information
1 parent
773530e
commit 36c6eeb
Showing
6 changed files
with
8 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters