Discuss more elegant way for formatting text as currency

This is the current code to format text as currency:

https://github.com/OpenApoc/OpenApoc/blob/ae5d789cdd1d1d0d3bb86e86ac2085f0e35f481f/library/strings.cpp#L177-L205

It's a very manual process of
- checking characters that can appear in currency strings but shouldn't be considered for the digits count (minus, comma, etc)
- checking string length
- adding a comma every three digits, from right to left

I'm opening this request to discuss if there's a more elegant and appropriate way of doing this instead of reinventing the wheel like we have right now.

	const auto textLenght = Text.length();

	if (!Text.empty() && textLenght <= 3)
	return Text;

	auto isNumber = true;

	for (const auto &ch : Text)
	{
	// Allowed chars in strings containing monetary values
	if (!std::isdigit(ch) && ch != '.' && ch != ',' && ch != '-')
	{
	isNumber = false;
	break;
	}
	}

	if (!isNumber)
	return Text;

	auto formattedText = Text; // copy text for formatting

	for (auto i = textLenght - 1; i > 0; i--)
	{
	if ((textLenght - i) % 3 == 0 && formattedText[i - 1] != '-')
	formattedText.insert(i, ",");
	}

	return formattedText;

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Discuss more elegant way for formatting text as currency #1469

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development