Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] User snippets are broken after #2253 #2254

Closed
vchirikov opened this issue Oct 20, 2021 · 3 comments
Closed

[Bug] User snippets are broken after #2253 #2254

vchirikov opened this issue Oct 20, 2021 · 3 comments

Comments

@vchirikov
Copy link

I have the user snippet:

{
	"ConfigureAwait": {
		"scope": "csharp",
		"prefix": "ca",
		"body": [
			".ConfigureAwait(false);",
		],
		"description": "Adds '.ConfigureAwait(false);'"
	},
}

Behavior before 1.37.17-beta.14 (1.37.17-beta.11):

before

Behavior after 1.37.17-beta.14:
after

cc: @JoeRobich
@JoeRobich
Copy link
Member

@vchirikov I can't reproduce this behavior. One thing I noticed from your very helpful gifs was that you brought up completion with 'ctrl+space' and in the first working example you dismissed it by pressing 'escape' before typing 'ca'. In the second failing example you didn't dismiss the completion popup. Can you try again on latest with the completion popup dismissed?

The completion that I changed it wholly separate from VS Code and its snippet support. OmniSharp-Roslyn has no impact on when custom VS Code snippets are offered or how they are committed.

@vchirikov
Copy link
Author

in the first working example you dismissed it by pressing 'escape' before typing 'ca'

I'm sorry, yep, looks like my fault, you're right
Sorry for bother you. 🙏

@JoeRobich
Copy link
Member

@vchirikov No worries. I see why it appears to be related. Thanks for using the C# extension!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoeRobich @vchirikov