Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement correlated random number generation #1069

Merged
merged 40 commits into from
Oct 3, 2022
Merged

Implement correlated random number generation #1069

Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
eefce12
[gulpy] first implementation
mtazzari Jul 5, 2022
a8f89de
[gulpy] implementing correlated rng
mtazzari Jul 5, 2022
d8215d8
[wip] implementing correlated rng
mtazzari Jul 6, 2022
614dd3d
[wip]
mtazzari Jul 12, 2022
d407089
[gulpy] working implementation of the correlated random values
mtazzari Jul 15, 2022
579910b
Merge branch 'develop' into feature/correlated_rng
mtazzari Jul 15, 2022
5417f9b
minor cleanup
mtazzari Jul 15, 2022
5ad10f9
[gulpy] Update docstrings for random module functions
mtazzari Jul 22, 2022
4f564a1
Merge branch 'develop' into feature/correlated_rng
mtazzari Aug 1, 2022
2066aa2
[gulpy] remove unused generate_correlated_hash
mtazzari Aug 2, 2022
f0311c0
[gulpy] introduce --ignore-correlation flag
mtazzari Aug 2, 2022
1709cee
set hashed_group_id to True by default, cleanup
mtazzari Aug 3, 2022
2222be2
adding haahing patch
maxwellflitton Aug 8, 2022
2c0d5e3
adding haahing patch
maxwellflitton Aug 8, 2022
6621208
Merge branch 'develop' into hashing-investigation
mtazzari Aug 10, 2022
e8cf544
Merge branch 'develop' into feature/correlated_rng
mtazzari Aug 11, 2022
bb05858
[gulpy] minor cleanup files.py parameter on same line
mtazzari Aug 11, 2022
e593f0c
[gulpy] run correlation only if rho>0
mtazzari Aug 11, 2022
fbf1689
updating hashing
maxwellflitton Aug 11, 2022
d611869
[gulpy] improve flow depending on corr definitions
mtazzari Aug 12, 2022
82fb79c
Disable GroupID hashing for acceptance tests (#1094)
sambles Aug 12, 2022
fee427e
Update group_id_cols default in get_gul_input_items
mtazzari Aug 12, 2022
45f8779
Hashing investigation (#1096)
maxwellflitton Aug 12, 2022
461621f
[gul_inputs] bugfix don't modify inplace
mtazzari Aug 12, 2022
77245a3
Update test_summaries.py to not rely on "loc_id" as default for group…
sambles Aug 12, 2022
bf500be
Always create a correlations.bin, if missing model_settings file is b…
sambles Aug 23, 2022
fd210e2
Merge branch 'develop' of https://github.com/OasisLMF/OasisLMF into h…
maxwellflitton Aug 24, 2022
2b3d202
adding peril_correlation_group for valid_oasis_group_cols
maxwellflitton Sep 5, 2022
f7cb1ab
adding peril_correlation_group for valid_oasis_group_cols
maxwellflitton Sep 5, 2022
7d772fb
appending peril_correlation_group to columns if correlations group is…
maxwellflitton Sep 5, 2022
e6ac89e
adding peril_correlation_group column to hashing of group IDs if corr…
maxwellflitton Sep 7, 2022
823add8
updating hashing group ID
maxwellflitton Sep 15, 2022
ff9f568
updating to accomodate non-correlations
maxwellflitton Sep 20, 2022
32a5f66
fixxing run
maxwellflitton Sep 21, 2022
d60deb2
fixing empty correlations df write header if empty correlations
maxwellflitton Sep 21, 2022
1fc5651
Merge branch 'develop' into feature/correlated_rng
sambles Oct 3, 2022
e95dac6
Remove empty file
sambles Oct 3, 2022
62c805f
Add missing defaults to get_gul_input_items (backwards compatible)
sambles Oct 3, 2022
5f6933a
Fix Group_id valid column check
sambles Oct 3, 2022
44e43f2
Force retest
sambles Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test_summaries.py to not rely on "loc_id" as default for group… 
…_id_cols
  • Loading branch information
@sambles
sambles committed Aug 12, 2022
commit 77245a3301fd1f4749b83cd4c6b6e2d8dc208519
6 changes: 3 additions & 3 deletions tests/model_preparation/test_summaries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def test_single_peril__totals_correct(self, data):
)

# Run Gul Proccessing
gul_inputs = get_gul_input_items(loc_df, keys_df)
gul_inputs = get_gul_input_items(loc_df, keys_df, group_id_cols=['loc_id'])
gul_inputs = gul_inputs[gul_inputs['status'].isin(OASIS_KEYS_STATUS_MODELLED)]

# Fetch expected TIVS
Expand Down Expand Up @@ -200,7 +200,7 @@ def test_multi_perils__single_covarage(self, data):
# Run Summary output check
self.assertSummaryIsValid(
loc_df,
get_gul_input_items(loc_df, keys_df),
get_gul_input_items(loc_df, keys_df, group_id_cols=['loc_id']),
get_exposure_summary(exposure_df=loc_df, keys_df=keys_df),
perils_returned
)
Expand Down Expand Up @@ -244,7 +244,7 @@ def test_multi_perils__multi_covarage(self, data):

# Run Summary output check
exp_summary = get_exposure_summary(exposure_df=loc_df, keys_df=keys_df)
gul_inputs = get_gul_input_items(loc_df, keys_df)
gul_inputs = get_gul_input_items(loc_df, keys_df, group_id_cols=['loc_id'])
self.assertSummaryIsValid(
loc_df,
gul_inputs,
Expand Down