issue#152 data folder es6 migration #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlisesGascon
requested changes
Aug 29, 2019
config/env/development.js
Outdated
| @@ -5,7 +5,7 @@ module.exports = { | |||
| // grunt db-reset:development | |||
| // That will create the local nodegoat data-store, or restore it to a clean state if it already exists. | |||
|
|
|||
| // db: "mongodb://localhost:27017/nodegoat", | |||
| db: "mongodb://localhost:27017/nodegoat", | |||
There was a problem hiding this comment.
This should remind commented ;-)
|
|
||
| // Create allocations document | ||
| var memos = { | ||
| const memos = { | ||
| memo: memo, |
There was a problem hiding this comment.
we can use shorter assignation here too ^^
ckarande
approved these changes
Sep 3, 2019
There was a problem hiding this comment.
👍 Thanks for your contribution @lucas1004jx and help with reviewing it @UlisesGascon
UlisesGascon
approved these changes
Sep 9, 2019
This was referenced Sep 9, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of Migration to es6+ #152.
As this tasks is huge, we agreed to split it in little chunks so it can be review it faster 👍
PR Changelog
change 'var' to 'const'
change function to ES& arrow function