Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change var to let and const #163

Merged
merged 1 commit into from
Aug 14, 2019
Merged

change var to let and const #163

merged 1 commit into from
Aug 14, 2019

Conversation

lucas1004jx
Copy link
Contributor

Context:

This PR is part of Migration to es6+ #152.
As this tasks is huge, we agreed to split it in little chunks so it can be review it faster 👍

PR Changelog

change 'var' to 'const'
change function to ES& arrow function

UlisesGascon
UlisesGascon approved these changes Aug 14, 2019
View reviewed changes
Copy link
Collaborator

@UlisesGascon UlisesGascon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ^^

I changed the PR target to branch OWASP:release-1.5

@UlisesGascon UlisesGascon changed the base branch from master to release-1.5 August 14, 2019 07:22
@UlisesGascon UlisesGascon merged commit 0916146 into OWASP:release-1.5 Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucas1004jx @UlisesGascon