Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging updated examples into develop. #4

Closed
wants to merge 5 commits into from
Closed

Conversation

Cogswatch
Copy link
Contributor

No description provided.

@Cogswatch Cogswatch self-assigned this Jul 17, 2019
@Cogswatch Cogswatch closed this Jul 17, 2019
@Cogswatch
Copy link
Contributor Author

Holding off on merge until later date

@lukegoertzen
Copy link
Member

lukegoertzen commented Jul 17, 2019

Thought this was fixed in develop already (further improved in new_sensors branch)

@Cogswatch
Copy link
Contributor Author

Seeing as how master is the front facing branch, I fixed all cases of it there since it is still an issue. Doesn't seem like a good idea to have broken examples in the version that people would actually be working with so I treated it as a hotfix and slapped it in there, merge was conflicting so I closed it and will address that in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants