Network Manager M1 remaining tasks #5762
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
schaable
changed the title
v-next/hardhat/test/internal/builtin-plugins/network-manager/hook-handlers/config.ts
Outdated
Show resolved
Hide resolved
| validationErrors.length > 0, | ||
| "validation errors should be present", | ||
| ); | ||
| // TODO: the error message should be "Expected a URL or a Configuration Variable" |
There was a problem hiding this comment.
The interesting thing is that this validation uses conditionalUnionType behind the scenes, so it might be bugged as well.
There was a problem hiding this comment.
I think this is working as intended concerning the conditionalUnionType. Its main idea is to return errors that are as specific as possible.
unionType does the contrary. It always returns a less specific error message.
Maybe for this particular case we should use unionType.
There was a problem hiding this comment.
the problem is that unionType expects the first argument to be an array of zod types, and we're using isObject in sensitiveUrlType. Maybe we could replace it with z.object() or z.record(), but we'd need to make it generic.
There was a problem hiding this comment.
I've updated sensitiveUrlType and sensitiveStringType to use unionType (and renamed them to schemas). However, there's a bug in Zod that prevents the union from using the provided errorMap when the string schema is z.string().url() (and likely other validations). See:
hardhat/v-next/hardhat-zod-utils/src/index.ts
Lines 156 to 160 in ae00903
schaable
force-pushed
the
network-manager-m1-cleanup
branch
from
bb29501
to
9b46702
Compare
v-next/hardhat/src/internal/builtin-plugins/network-manager/type-validation.ts
Outdated
Show resolved
Hide resolved
schaable
force-pushed
the
network-manager-m1-cleanup
branch
from
c5f2a4a
to
3541c81
Compare
schaable
force-pushed
the
network-manager-m1-cleanup
branch
from
3541c81
to
ae00903
Compare
This PR addresses most of the tasks outlined in this document, except for the "Types" section, which will be addressed in a separate PR. I suggest reviewing one commit at a time for an easier review process.
Summary:
extendUserConfig,validateUserConfig,resolveUserConfig).HTTPProvider:jsonRpcWrapperandclosefunctions.NetworkManager:connectfunction and all network hooks (newConnection,closeConnection,onRequest).NetworkConnection: class initialization andclosefunction (throughNetworkManager)