Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swiftlint: 0.57.1 -> 0.58.0 #373261

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

DimitarNestorov
Copy link
Member

Things done

Updated SwiftLint: https://github.com/realm/SwiftLint/releases/tag/0.58.0
Tested manually, all good:

$ nix-build -A swiftlint
/nix/store/i7723crvhhysi71h6djbjw1pffl8wqia-swiftlint-0.58.0
$ echo "class test{}

var a = 1" > test.swift
$ ./result/bin/swiftlint test.swift
Linting Swift files at paths test.swift
Linting 'test.swift' (1/1)
/Users/dimitar/Projects/nixpkgs/test.swift:3:5: error: Identifier Name Violation: Variable name 'a' should be between 3 and 40 characters long (identifier_name)
/Users/dimitar/Projects/nixpkgs/test.swift:1:11: warning: Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
/Users/dimitar/Projects/nixpkgs/test.swift:1:7: error: Type Name Violation: Type name 'test' should start with an uppercase character (type_name)
Done linting! Found 3 violations, 2 serious in 1 file.
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 12, 2025
@nix-owners nix-owners bot requested a review from matteo-pacini January 12, 2025 18:50
@DimitarNestorov DimitarNestorov added 8.has: package (update) This PR updates a package to a newer version 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels Jan 12, 2025
Copy link
Contributor

@matteo-pacini matteo-pacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373261


x86_64-darwin

✅ 1 package built:
  • swiftlint

aarch64-darwin

✅ 1 package built:
  • swiftlint

@matteo-pacini matteo-pacini added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jan 13, 2025
@FliegendeWurst FliegendeWurst added the 6.topic: darwin Running or building packages on Darwin label Jan 14, 2025
@FliegendeWurst FliegendeWurst merged commit 3f70aca into NixOS:master Jan 14, 2025
50 of 53 checks passed
@DimitarNestorov DimitarNestorov deleted the update-swiftlint branch January 15, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants