Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kde-geometry-change: init at 1.3 #373151

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hatch01
Copy link
Contributor

@hatch01 hatch01 commented Jan 12, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/kde/default.nix Outdated Show resolved Hide resolved
pkgs/kde/third-party/kde-geometry-change/default.nix Outdated Show resolved Hide resolved
};

nativeBuildInputs = [
nodejs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is node necessary here then?

runHook postInstall
'';

LANG = "C.UTF-8";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this even affect?

@hatch01 hatch01 force-pushed the kwin4_effect_geometry_change branch 2 times, most recently from 7b61a5a to 2c28bd6 Compare January 12, 2025 18:10
pkgs/kde/default.nix Outdated Show resolved Hide resolved
@hatch01 hatch01 force-pushed the kwin4_effect_geometry_change branch from 2c28bd6 to cf27756 Compare January 12, 2025 18:14
@hatch01 hatch01 marked this pull request as draft January 12, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants