Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.11] mpris-timer: 1.6.2 -> 2.0.3 #373086

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Jan 12, 2025

Manual backport of #372567

Even though this is a major version bump, it doesn't seem there are any actual breaking changes (and previous versions are very unlikely to ever be updated)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 12, 2025
@nix-owners nix-owners bot requested a review from Stunkymonkey January 12, 2025 01:34
@getchoo
Copy link
Member Author

getchoo commented Jan 12, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373086


aarch64-linux

✅ 1 package built:
  • mpris-timer

@wolfgangwalther
Copy link
Contributor

If you backport with the -x option for git cherry-pick, the cherry-pick CI job will pick it up and check that it matches the original commit. This makes it much easier as a reviewer.

This is explained in the contribution guidelines: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#manually-backporting-changes

Though, in this case the changes are easily checked manually, it's only 3 lines.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jan 12, 2025
@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373086


x86_64-linux

✅ 1 package built:
  • mpris-timer

@wolfgangwalther wolfgangwalther merged commit 4fc09bd into NixOS:release-24.11 Jan 12, 2025
25 checks passed
@getchoo getchoo deleted the backport-372567-to-release-24.11 branch January 12, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants