Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apt, dpkg: fix cross build #372955

Merged
merged 2 commits into from
Jan 13, 2025
Merged

apt, dpkg: fix cross build #372955

merged 2 commits into from
Jan 13, 2025

Conversation

FliegendeWurst
Copy link
Member

Also fix regular strictDeps, ref. #178468

Things done

  • Built on platform(s)
    • x86_64-linux: and cross to aarch64
    • aarch64-linux
  • Fits CONTRIBUTING.md.

@nix-owners nix-owners bot requested a review from siriobalmelli January 11, 2025 15:21
@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Jan 12, 2025
siriobalmelli
siriobalmelli approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@siriobalmelli siriobalmelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dpk also continues to build fine on aarch64-linux and aarch64-darwin

@FliegendeWurst FliegendeWurst merged commit 7d4cd94 into NixOS:master Jan 13, 2025
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriobalmelli siriobalmelli siriobalmelli approved these changes

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FliegendeWurst @siriobalmelli