Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bird: 2.16 -> 2.16.1 #372920

Merged
merged 1 commit into from
Jan 14, 2025
Merged

bird: 2.16 -> 2.16.1 #372920

merged 1 commit into from
Jan 14, 2025

Conversation

herbetom
Copy link
Member

@herbetom herbetom commented Jan 11, 2025 •
edited
Loading

Changelog:

  • ASPA: fixed parser bug in static protocol
  • ASPA: fixed static protocol reconfiguration
  • Babel: fixed seqno comparison
  • BSD: fixed onlink flag assumption with Netlink
  • Fixed memory alignment issues
  • Fixed possible rte src collisions in L3VPN

Source: https://gitlab.nic.cz/labs/bird/-/blob/v2.16.1/NEWS

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 11, 2025
@herbetom
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372920

x86_64-linux

✅ 1 package built:
  • bird

aarch64-linux

✅ 1 package built:
  • bird

@herbetom herbetom added backport release-24.11 Backport PR automatically 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels Jan 11, 2025
@herbetom herbetom mentioned this pull request Jan 11, 2025
Closed
13 tasks
niklaskorz
niklaskorz approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@niklaskorz niklaskorz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bird user, but package builds fine and tests (nixosTests.bird) are passing on x86_64-linux

@niklaskorz niklaskorz requested a review from NickCao January 13, 2025 19:24
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 14, 2025
NickCao
NickCao approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my "routers".

@NickCao NickCao merged commit cabd944 into NixOS:master Jan 14, 2025
59 of 70 checks passed
@herbetom herbetom deleted the update-bird2 branch January 14, 2025 15:24
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 14, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jan 14, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCao NickCao NickCao approved these changes

@niklaskorz niklaskorz niklaskorz approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@herbetom @niklaskorz @NickCao @wegank