Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librewolf-bin: 133.0.3-1 -> 134.0-1 #372676

Merged
merged 1 commit into from
Jan 11, 2025
Merged

librewolf-bin: 133.0.3-1 -> 134.0-1 #372676

merged 1 commit into from
Jan 11, 2025
+2 −2

Conversation

DominicWrege
Copy link
Contributor

@DominicWrege DominicWrege commented Jan 10, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 10, 2025
eljamm
eljamm approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@eljamm eljamm added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 10, 2025
@DominicWrege
Copy link
Contributor Author

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@DominicWrege merge not permitted (#305350):
CommitterPR: pr author is not committer
R-Ryantm Maintainer merge: pr author is not r-ryantm

@donovanglover donovanglover added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jan 11, 2025
@FliegendeWurst FliegendeWurst merged commit a3943c9 into NixOS:master Jan 11, 2025
32 checks passed
@Schweber Schweber added the backport release-24.11 Backport PR automatically label Jan 12, 2025
@nixpkgs-ci
Copy link

nixpkgs-ci bot commented Jan 12, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jan 12, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eljamm eljamm eljamm approved these changes

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DominicWrege @FliegendeWurst @eljamm @donovanglover @Schweber