Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron{-source,-bin,-chromedriver}: 32.2.7 -> 32.2.8, 33.3.0 -> 33.3.1 #371868

Merged
merged 6 commits into from
Jan 11, 2025
Merged

electron{-source,-bin,-chromedriver}: 32.2.7 -> 32.2.8, 33.3.0 -> 33.3.1 #371868

merged 6 commits into from
Jan 11, 2025
+40 −40

Conversation

emilylange
Copy link
Member

Will run nixpkgs-review on x86_64-linux and report back when it's done :)

Let me know if I messed something up.

https://github.com/electron/electron/releases/tag/v32.2.8
electron/electron@refs/tags/v32.2.7...v32.2.8
Fixes CVE-2024-12053

https://github.com/electron/electron/releases/tag/v33.3.1
electron/electron@refs/tags/v33.3.0...v33.3.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@emilylange
electron_32-bin: 32.2.7 -> 32.2.8
06b8d2d 
- Changelog: https://github.com/electron/electron/releases/tag/v32.2.8
- Diff: electron/electron@refs/tags/v32.2.7...v32.2.8
- Fixes CVE-2024-12053
@emilylange
electron_33-bin: 33.3.0 -> 33.3.1
1ffe14a 
- Changelog: https://github.com/electron/electron/releases/tag/v33.3.1
- Diff: electron/electron@refs/tags/v33.3.0...v33.3.1
@emilylange
electron-source.electron_32: 32.2.7 -> 32.2.8
d983ac0 
- Changelog: https://github.com/electron/electron/releases/tag/v32.2.8
- Diff: electron/electron@refs/tags/v32.2.7...v32.2.8
- Fixes CVE-2024-12053
@emilylange
electron-source.electron_33: 33.3.0 -> 33.3.1
9151841 
- Changelog: https://github.com/electron/electron/releases/tag/v33.3.1
- Diff: electron/electron@refs/tags/v33.3.0...v33.3.1
@emilylange
electron-chromedriver_32: 32.2.7 -> 32.2.8
7c87378 
- Changelog: https://github.com/electron/electron/releases/tag/v32.2.8
- Diff: electron/electron@refs/tags/v32.2.7...v32.2.8
- Fixes CVE-2024-12053
@emilylange
electron-chromedriver_33: 33.3.0 -> 33.3.1
60d086b 
- Changelog: https://github.com/electron/electron/releases/tag/v33.3.1
- Diff: electron/electron@refs/tags/v33.3.0...v33.3.1
@emilylange emilylange added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-24.11 Backport PR automatically labels Jan 7, 2025
@emilylange
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371868

x86_64-linux

❌ 1 package failed to build:
  • ride
✅ 88 packages built:
  • affine
  • affine-bin
  • antares
  • antimatter-dimensions
  • bilibili
  • bitwarden-desktop
  • bitwarden-directory-connector
  • blockbench
  • bruno
  • camunda-modeler
  • caprine
  • catalyst-browser
  • chatd
  • deltachat-desktop
  • drawio
  • drawio-headless
  • electron (electron_33)
  • electron-bin (electron_33-bin)
  • electron-chromedriver (electron-chromedriver_33)
  • electron-chromedriver_32
  • electron_32
  • electron_32-bin
  • element-desktop
  • equibop
  • fcast-receiver
  • follow
  • freetube
  • gdlauncher-carbon
  • gfn-electron
  • gitify
  • goofcord
  • google-chat-linux
  • headset
  • heroic
  • heroic-unwrapped
  • httptoolkit
  • itch
  • jitsi-meet-electron
  • kando
  • koodo-reader
  • kuro
  • legcord
  • marktext
  • mattermost-desktop
  • morgen
  • mqtt-explorer
  • nix-tour
  • obsidian
  • open-stage-control
  • openfortivpn-webview
  • pandoc-drawio-filter
  • pandoc-drawio-filter.dist
  • podman-desktop
  • pritunl-client
  • proton-pass
  • protonmail-desktop
  • python312Packages.mkdocs-drawio-exporter
  • python312Packages.mkdocs-drawio-exporter.dist
  • python313Packages.mkdocs-drawio-exporter
  • python313Packages.mkdocs-drawio-exporter.dist
  • r2modman
  • redisinsight
  • revolt-desktop
  • sharedown
  • sieve-editor-gui
  • siyuan
  • standardnotes
  • stretchly
  • super-productivity
  • teams-for-linux
  • terra-station
  • tetrio-desktop
  • thedesk
  • threema-desktop
  • uhk-agent
  • uhk-udev-rules
  • uivonim
  • vesktop
  • vieb
  • voicevox
  • webcord
  • webtorrent_desktop
  • yandex-music
  • youtube-music
  • ytdownloader
  • ytmdesktop
  • zepp-simulator
  • zulip

element-desktop, electron-source.electron_32 and electron-source.electron_33 all start and appear to work under x86_64-linux (wayland).

The one failure (ride) appears to be unrelated.
ride fails on the latest master and on hydra for some while now: https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.ride.x86_64-linux and https://hydra.nixos.org/build/282539817

@emilylange emilylange mentioned this pull request Jan 10, 2025
Merged
13 tasks
teutat3s
teutat3s approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@teutat3s teutat3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for taking care of the bump.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 11, 2025
@emilylange emilylange merged commit 1e1709d into NixOS:master Jan 11, 2025
27 of 30 checks passed
@emilylange emilylange deleted the electron branch January 11, 2025 17:23
@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jan 11, 2025
Open
1 task
@nixpkgs-ci
Copy link

nixpkgs-ci bot commented Jan 11, 2025

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teutat3s teutat3s teutat3s approved these changes

@liam-murphy14 liam-murphy14 Awaiting requested review from liam-murphy14

@yayayayaka yayayayaka Awaiting requested review from yayayayaka

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilylange @teutat3s @wegank