Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jesec-rtorrent: 0.9.8-r16 -> 0.9.8-r16-unstable-2023-07-21 #371676

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vamega
Copy link
Contributor

@vamega vamega commented Jan 7, 2025

Bumping package to unreleased commit to fix #371518

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 7, 2025
@vamega vamega changed the title jesec-rtorrent.libtorrent: 0.13.8-r4 -> 0.13.8-r4-unstable-2023-07-04 jesec-rtorrent: 0.9.8-r16 -> 0.9.8-r16-unstable-2023-07-21 Jan 8, 2025
@nix-owners nix-owners bot requested a review from winterqt January 8, 2025 17:11
Copy link
Member

@winterqt winterqt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just apply jesec/libtorrent@ed30d71 instead? Not 100% thrilled about shipping a (technically) bleeding-edge build of this for swarm etiquette reasons, especially since this is still a fork.

Open to hearing your thoughts if you actively use the software (though it's OK if you're just interested in fixing it because of the issue!)

@winterqt
Copy link
Member

winterqt commented Jan 9, 2025

I'm also considering dropping this package entirely in favor of vanilla, now that upstream has picked up steam again (and downstream/jesec development is stalled).

@winterqt
Copy link
Member

winterqt commented Jan 9, 2025

I'm also considering dropping this package entirely in favor of vanilla, now that upstream has picked up steam again (and downstream/jesec development is stalled).

@kannibalox If I'm remembering correct, you're a pretty heavy user of rTorrent (correct me if I'm wrong)? Were you ever using jesec's fork (as your PRs to his indicate), and if so, did you switch to vanilla when 0.15.0 was cut?

cc @pshirshov for additional thoughts as you've indicated you're a user of jesec's fork as you opened the issue. Is there a killer feature that keeps you on jesec's fork now that upstream has 0.15.0 now? (JSON-RPC and misc. performance improvements I guess?)

@pshirshov
Copy link
Contributor

I've been using it with flood, so yes, the rpc.

@kannibalox
Copy link

@kannibalox If I'm remembering correct, you're a pretty heavy user of rTorrent (correct me if I'm wrong)? Were you ever using jesec's fork (as your PRs to his indicate), and if so, did you switch to vanilla when 0.15.0 was cut?

I'm currently still using my own modified version of jesec's fork, but one of my goals is to get vanilla to point where I don't have to do that anymore (e.g. I just opened a PR for JSON-RPC support). Some of the things compilation things jesec does (linking to mimalloc, compiling with C++17) can still be done on vanilla, if that sounds of interest to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: jecec-rtorrent
4 participants