-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jesec-rtorrent: 0.9.8-r16 -> 0.9.8-r16-unstable-2023-07-21 #371676
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should just apply jesec/libtorrent@ed30d71 instead? Not 100% thrilled about shipping a (technically) bleeding-edge build of this for swarm etiquette reasons, especially since this is still a fork.
Open to hearing your thoughts if you actively use the software (though it's OK if you're just interested in fixing it because of the issue!)
I'm also considering dropping this package entirely in favor of vanilla, now that upstream has picked up steam again (and downstream/jesec development is stalled). |
@kannibalox If I'm remembering correct, you're a pretty heavy user of rTorrent (correct me if I'm wrong)? Were you ever using jesec's fork (as your PRs to his indicate), and if so, did you switch to vanilla when 0.15.0 was cut? cc @pshirshov for additional thoughts as you've indicated you're a user of jesec's fork as you opened the issue. Is there a killer feature that keeps you on jesec's fork now that upstream has 0.15.0 now? (JSON-RPC and misc. performance improvements I guess?) |
I've been using it with flood, so yes, the rpc. |
I'm currently still using my own modified version of jesec's fork, but one of my goals is to get vanilla to point where I don't have to do that anymore (e.g. I just opened a PR for JSON-RPC support). Some of the things compilation things jesec does (linking to mimalloc, compiling with C++17) can still be done on vanilla, if that sounds of interest to you. |
Bumping package to unreleased commit to fix #371518
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.