Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.oelint-parser: 5.1.0 -> 6.5.0, oelint-adv: 6.1.0 -> 6.6.6 #369754

Merged
merged 2 commits into from
Jan 6, 2025
Merged

python312Packages.oelint-parser: 5.1.0 -> 6.5.0, oelint-adv: 6.1.0 -> 6.6.6 #369754

merged 2 commits into from
Jan 6, 2025

Conversation

otavio
Copy link
Contributor

@otavio otavio commented Dec 31, 2024 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@otavio otavio requested a review from NickCao December 31, 2024 19:39
@lucasew
Copy link
Contributor

lucasew commented Jan 1, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369754

x86_64-linux

✅ 8 packages built:
  • bitbake-language-server
  • bitbake-language-server.dist
  • oelint-adv
  • oelint-adv.dist
  • python312Packages.oelint-parser
  • python312Packages.oelint-parser.dist
  • python313Packages.oelint-parser
  • python313Packages.oelint-parser.dist

1 similar comment
@thiagokokada
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369754

x86_64-linux

✅ 8 packages built:
  • bitbake-language-server
  • bitbake-language-server.dist
  • oelint-adv
  • oelint-adv.dist
  • python312Packages.oelint-parser
  • python312Packages.oelint-parser.dist
  • python313Packages.oelint-parser
  • python313Packages.oelint-parser.dist

@thiagokokada
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369754

aarch64-darwin

❌ 4 packages failed to build:
  • bitbake-language-server
  • bitbake-language-server.dist
  • oelint-adv
  • oelint-adv.dist
✅ 4 packages built:
  • python312Packages.oelint-parser
  • python312Packages.oelint-parser.dist
  • python313Packages.oelint-parser
  • python313Packages.oelint-parser.dist

@thiagokokada
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369754

x86_64-darwin

❌ 4 packages failed to build:
  • bitbake-language-server
  • bitbake-language-server.dist
  • oelint-adv
  • oelint-adv.dist
✅ 4 packages built:
  • python312Packages.oelint-parser
  • python312Packages.oelint-parser.dist
  • python313Packages.oelint-parser
  • python313Packages.oelint-parser.dist

@otavio
Copy link
Contributor Author

otavio commented Jan 3, 2025

@thiagokokada I have applied the suggested changes. Please review it again.

@thiagokokada
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369754

x86_64-linux

✅ 8 packages built:
  • bitbake-language-server
  • bitbake-language-server.dist
  • oelint-adv
  • oelint-adv.dist
  • python312Packages.oelint-parser
  • python312Packages.oelint-parser.dist
  • python313Packages.oelint-parser
  • python313Packages.oelint-parser.dist

@thiagokokada
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369754

aarch64-darwin

❌ 4 packages failed to build:
  • bitbake-language-server
  • bitbake-language-server.dist
  • oelint-adv
  • oelint-adv.dist
✅ 4 packages built:
  • python312Packages.oelint-parser
  • python312Packages.oelint-parser.dist
  • python313Packages.oelint-parser
  • python313Packages.oelint-parser.dist

@thiagokokada
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369754

x86_64-darwin

❌ 4 packages failed to build:
  • bitbake-language-server
  • bitbake-language-server.dist
  • oelint-adv
  • oelint-adv.dist
✅ 4 packages built:
  • python312Packages.oelint-parser
  • python312Packages.oelint-parser.dist
  • python313Packages.oelint-parser
  • python313Packages.oelint-parser.dist

@lucasew
Copy link
Contributor

lucasew commented Jan 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369754

x86_64-linux

✅ 8 packages built:
  • bitbake-language-server
  • bitbake-language-server.dist
  • oelint-adv
  • oelint-adv.dist
  • python312Packages.oelint-parser
  • python312Packages.oelint-parser.dist
  • python313Packages.oelint-parser
  • python313Packages.oelint-parser.dist

@thiagokokada
Copy link
Contributor

@otavio Did you disable the GitHub Actions from your Nixpkgs fork? I think this could be the reason why Eval / Tag check is failing.

@otavio
Copy link
Contributor Author

otavio commented Jan 3, 2025

I didn't. I just check it and they are enabled in my fork.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 2.status: merge conflict This PR has merge conflicts with the target branch labels Jan 3, 2025
otavio added 2 commits January 6, 2025 14:39
@otavio
python312Packages.oelint-parser: 5.1.0 -> 6.5.0
34a69e1 
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
@otavio
oelint-adv: 6.1.0 -> 6.6.6
8c6f4ad 
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 6, 2025
@otavio
Copy link
Contributor Author

otavio commented Jan 6, 2025

@thiagokokada please merge this?

@thiagokokada thiagokokada merged commit 3a4eefe into NixOS:master Jan 6, 2025
23 of 27 checks passed
@otavio otavio deleted the oelint-adv branch January 7, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@NickCao NickCao Awaiting requested review from NickCao

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@otavio @lucasew @thiagokokada @wegank