Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/powertop: add hooks to fix incorrect configurations #368163

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

MakiseKurisu
Copy link
Contributor

powertop will set USB auto suspend for all connected devices to auto. This can be checked with head /sys/bus/usb/devices/*/power/control.

However, the reason this is not auto by default is because some devices does not support this properly. I'm getting the same issue as described here on my Logitech mouse, and I have confirmed that the workaround there works.

As such, let's expose postStart to allow arbitrary fixup script, since there might be other types of buggy hardware. I included an udev based example, since this is more declarative (locate device by VID and PID) than some custom bash scripts to iterate all /sys/bus/usb/devices nodes.

While we are on it, let's also expose preStart. Though I can't think of any obvious usage right now. Maybe rmmod some drivers so they won't be affected by power setting changes, and re-enable them in postStart? It is more about the completeness at this point.

As usual, I'm dogfooding this PR.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 25, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 25, 2024
@Mic92 Mic92 merged commit 43ec9a5 into NixOS:master Dec 25, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants