Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bigpemu: init at 1.17 #366367

Merged
merged 2 commits into from
Jan 12, 2025
Merged

bigpemu: init at 1.17 #366367

merged 2 commits into from
Jan 12, 2025

Conversation

Tombert
Copy link
Contributor

@Tombert Tombert commented Dec 18, 2024 •
edited by FliegendeWurst
Loading

Add a package for BigPEmu. Already tested in a flake (https://github.com/Tombert/BigPEmuFlakeMake).

Fixes #310593

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Tombert Tombert force-pushed the bigpemu branch 9 times, most recently from 07d8e50 to a403e40 Compare December 19, 2024 00:09
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Dec 19, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 19, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 19, 2024
@hughobrien
Copy link
Contributor

I suggest splitting into two commits with one being: maintainers: add tombert

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 1 labels Dec 22, 2024
@Tombert Tombert force-pushed the bigpemu branch 3 times, most recently from 5a88161 to 25aeda7 Compare December 22, 2024 06:17
@hughobrien
Copy link
Contributor

Updater script: https://github.com/hughobrien/nixpkgs/tree/bigpemu

@hughobrien
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 366367

x86_64-linux

✅ 1 package built:
  • bigpemu

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Dec 22, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 23, 2024
@Tombert Tombert mentioned this pull request Dec 30, 2024
Closed
@keenanweaver
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 366367

x86_64-linux

✅ 1 package built:
  • bigpemu

keenanweaver
keenanweaver approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@keenanweaver keenanweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thank you!
Screenshot_20241230_070714

@keenanweaver keenanweaver added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 30, 2024
@FliegendeWurst FliegendeWurst merged commit 4e4488b into NixOS:master Jan 12, 2025
54 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keenanweaver keenanweaver keenanweaver approved these changes

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

@hughobrien hughobrien hughobrien approved these changes

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: bigpemu
5 participants
@Tombert @hughobrien @keenanweaver @FliegendeWurst @wegank