Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.dugong: deprecate #364731

Merged
merged 2 commits into from
Jan 11, 2025
Merged

python3Packages.dugong: deprecate #364731

merged 2 commits into from
Jan 11, 2025

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Dec 12, 2024 •
edited
Loading

part of #346385: see s3ql/s3ql@9819f85

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Stunkymonkey Stunkymonkey mentioned this pull request Dec 12, 2024
Open
25 tasks
@github-actions github-actions bot added 6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 12, 2024
@Stunkymonkey
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 364731

x86_64-linux

✅ 2 packages built:
  • s3ql
  • s3ql.dist

@Stunkymonkey Stunkymonkey marked this pull request as ready for review December 12, 2024 22:43
@nix-owners nix-owners bot requested a review from natsukium December 12, 2024 22:44
@ofborg ofborg bot requested a review from rushmorem December 13, 2024 16:28
eljamm
eljamm approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to be merged.

@eljamm eljamm added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 10, 2025
@Stunkymonkey Stunkymonkey merged commit 20363d8 into NixOS:master Jan 11, 2025
63 checks passed
@Stunkymonkey Stunkymonkey deleted the deprecate-dugong branch January 11, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eljamm eljamm eljamm approved these changes

@fabaff fabaff Awaiting requested review from fabaff

@emilazy emilazy Awaiting requested review from emilazy

@natsukium natsukium Awaiting requested review from natsukium

@rushmorem rushmorem Awaiting requested review from rushmorem

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stunkymonkey @eljamm