Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-assistant-custom-lovelace-modules.vacuum-card: init at 2.10.1 #357070

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

Golbinex
Copy link
Contributor

Adds vacuum-card Lovelace module for controlling robots.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Golbinex
Copy link
Contributor Author

nixpkgs-review output:
1 package built: home-assistant-custom-lovelace-modules.vacuum-card

@nix-owners nix-owners bot requested a review from mweinelt November 18, 2024 20:10
@FliegendeWurst
Copy link
Member

@ofborg build home-assistant-custom-lovelace-modules.vacuum-card

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 29, 2024
@mweinelt
Copy link
Member

The commit message needs to use the full attribute name.

@FliegendeWurst FliegendeWurst added the awaiting_changes (old Marvin label, do not use) label Dec 4, 2024
@Golbinex Golbinex changed the title vacuum-card: init at 2.10.1 home-assistant-custom-lovelace-modules.vacuum-card: init at 2.10.1 Dec 6, 2024
@Golbinex
Copy link
Contributor Author

Golbinex commented Dec 6, 2024

@mweinelt Done.

@mweinelt mweinelt merged commit 11b9fa4 into NixOS:master Dec 6, 2024
25 of 26 checks passed
@Golbinex
Copy link
Contributor Author

Golbinex commented Dec 7, 2024

@mweinelt Thanks, can you take a look at #356473 as well?

@Golbinex Golbinex deleted the patch branch December 7, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person awaiting_changes (old Marvin label, do not use)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants