Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phylophlan: init at 3.1.1 #356788

Merged
merged 1 commit into from
Jan 11, 2025
Merged

phylophlan: init at 3.1.1 #356788

merged 1 commit into from
Jan 11, 2025

Conversation

theobori
Copy link
Member

Fixes #343368

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@theobori theobori mentioned this pull request Nov 17, 2024
Closed
13 tasks
steeleduncan
steeleduncan reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@steeleduncan steeleduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not the maintainer, so it makes no sense for me to leave an approving review, but looks good to me!

@Pandapip1
Copy link
Contributor

I'm not the maintainer, so it makes no sense for me to leave an approving review, but looks good to me!

Actually, everyone is encouraged to leave reviews! See https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#how-to-review-pull-requests

Pandapip1
Pandapip1 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 22, 2024
@x123
Copy link
Contributor

x123 commented Nov 29, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356788

x86_64-linux

✅ 2 packages built:
  • phylophlan
  • phylophlan.dist

@FliegendeWurst FliegendeWurst changed the title python3Packages.phylophlan: init at 3.1.1 phylophlan: init at 3.1.1 Dec 19, 2024
@FliegendeWurst FliegendeWurst merged commit 3568023 into NixOS:master Jan 11, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steeleduncan steeleduncan steeleduncan requested changes

@Pandapip1 Pandapip1 Pandapip1 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: phylophlan
6 participants
@theobori @Pandapip1 @x123 @steeleduncan @wegank @FliegendeWurst