Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-assistant-custom-components.dreame-vacuum: init at 1.0.4, python312Packages.py-mini-racer: init at 0.6.0 #356473

Closed
wants to merge 2 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
home-assistant-custom-components.dreame-vacuum: init at 1.0.4
  • Loading branch information
Golbinex committed Nov 16, 2024
commit e251436f3637a7a65aa518bd4674603e60cb4fe2
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
{
lib,
buildHomeAssistantComponent,
fetchFromGitHub,
python312Packages,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never consume python312Packages in home-assistant-custom-components. You must consume the same package set that home-assistant provides. To that end you can just consume the dependencies up here.

Suggested change
python312Packages,
numpy,
pillow,
...,

And please sort this list.

}:

buildHomeAssistantComponent rec {
owner = "Tasshack";
domain = "dreame_vacuum";
version = "1.0.4";

src = fetchFromGitHub {
inherit owner;
repo = "dreame-vacuum";
rev = "v${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "v${version}";
tag = "v${version}";

hash = "sha256-LeKD2dIeC/TsOl3Q2TLFQy7RjzbRwYmvKUUm3JVsz8E=";
};

propagatedBuildInputs = with python312Packages; [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
propagatedBuildInputs = with python312Packages; [
dependencies = [

pillow
numpy
pybase64
requests
pycryptodome
python-miio
py-mini-racer
tzlocal
paho-mqtt
Comment on lines +21 to +29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort.

];

meta = with lib; {
description = "Home Assistant integration for Dreame robot vacuums with map support";
homepage = "https://github.com/Tasshack/dreame-vacuum";
changelog = "https://github.com/Tasshack/dreame-vacuum/releases/tag/${version}";
maintainers = with maintainers; [ baksa ];
license = licenses.mit;
};
}