Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.color-operations: 0.1.4 -> 0.1.6 #346505

Merged
merged 1 commit into from
Jan 10, 2025
Merged

pythonPackages.color-operations: 0.1.4 -> 0.1.6 #346505

merged 1 commit into from
Jan 10, 2025

Conversation

autra
Copy link
Contributor

@autra autra commented Oct 4, 2024 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@autra autra self-assigned this Oct 4, 2024
@autra
Copy link
Contributor Author

autra commented Oct 4, 2024

Buils broken because upstream pins numpy at precisely 2.0.0: vincentsarago/color-operations#13

@ofborg ofborg bot requested review from sikmir, nialov, l0b0, willcohen, imincik and nh2 October 4, 2024 20:42
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 4, 2024
@sikmir
Copy link
Member

sikmir commented Nov 10, 2024

0.1.6 is out

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 4, 2025
@sikmir sikmir mentioned this pull request Jan 8, 2025
Closed
13 tasks
@autra autra force-pushed the color-operations-0.1.4-0.1.5 branch from bea8215 to dd11ed7 Compare January 10, 2025 11:30
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 10, 2025
@autra autra changed the title pythonPackages.color-operations: 0.1.4 -> 0.1.5 pythonPackages.color-operations: 0.1.4 -> 0.1.6 Jan 10, 2025
@autra autra marked this pull request as ready for review January 10, 2025 11:31
@autra
Copy link
Contributor Author

autra commented Jan 10, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 346505

x86_64-linux

⏩ 2 packages marked as broken and skipped:
  • python312Packages.rio-tiler
  • python312Packages.rio-tiler.dist
✅ 4 packages built:
  • python312Packages.color-operations
  • python312Packages.color-operations.dist
  • python313Packages.color-operations
  • python313Packages.color-operations.dist

imincik
imincik approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@imincik imincik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @autra . PR looks good and it unbreaking the package.

@imincik imincik merged commit c0b4b96 into NixOS:master Jan 10, 2025
48 of 52 checks passed
@imincik
Copy link
Contributor

imincik commented Jan 10, 2025

Ah, I just saw incorrect commit message "pythonPackages.color-operations: 0.1.4 -> 0.1.6" should be "python3Packages.color-operations: 0.1.4 -> 0.1.6" . Not sure what we can do.

@autra
Copy link
Contributor Author

autra commented Jan 10, 2025

Ah I forgot to edit this one indeed. Is it a big deal? It is still readable I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imincik imincik imincik approved these changes

@sikmir sikmir Awaiting requested review from sikmir

@nialov nialov Awaiting requested review from nialov

@l0b0 l0b0 Awaiting requested review from l0b0

@willcohen willcohen Awaiting requested review from willcohen

@nh2 nh2 Awaiting requested review from nh2

Assignees

@autra autra

Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@autra @sikmir @imincik @wegank