-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sqruff: init at 0.17.0 #342435
sqruff: init at 0.17.0 #342435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the PR title and commit message. Otherwise, LGTM. Link the PR with #336098 by adding fix https://github.com/NixOS/nixpkgs/issues/336098
to your description of PR.
Thanks @Bot-wxt1221, I've edited the commit messages, PR title and added a link to the relevant issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Commit should be name: |
Build fail. Read ofborg for detailed information. https://github.com/NixOS/nixpkgs/pull/342435/checks?check_run_id=30386821511 |
Fails with:
|
Very strange, it was working on my laptop earlier, maybe rebasing broke it? I'll see if I can push a fix :/ |
Ah, it's because originally I based this branch on the |
Oh sure ! Feel free to ping me again when the time has come. |
@GaetanLepage I believe this PR is ready for review again :) |
98456ff
to
a959c18
Compare
Co-authored-by: Gaétan Lepage <33058747+GaetanLepage@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
|
Description of changes
sqruff is a fast SQL linter and formatter.
fix #336098
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.