Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keybase: 6.2.3 -> 6.2.4; keybase-gui: 6.2.2 -> 6.2.4; backport to 23.11 #279429

Merged
merged 2 commits into from
Jan 21, 2024

Conversation

eyeinsky
Copy link
Contributor

@eyeinsky eyeinsky commented Jan 7, 2024

Description of changes

This is a backport to 23.11, both commits are already in unstable via these PRs:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@eyeinsky eyeinsky changed the title Backport keybase 6.2.4 to 23.11 keybase: 6.2.3 -> 6.2.4; keybase-gui: 6.2.2 -> 6.2.4; backport to 23.11 Jan 7, 2024
@teutat3s teutat3s added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 9, 2024
@eyeinsky eyeinsky force-pushed the backport-keybase-23.11 branch from d0799ec to b197636 Compare January 18, 2024 16:42
@eyeinsky
Copy link
Contributor Author

Fixed commit message here as well (from "Update keybase-gui from 6.2.2 to 6.2.4" to "keybase-gui: 6.2.2 -> 6.2.4")

@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 21, 2024
@h7x4 h7x4 merged commit 5bdb7d1 into NixOS:release-23.11 Jan 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants