Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-shuttle: 0.18.0 -> 0.19.0 #238766

Merged
merged 1 commit into from
Jun 20, 2023
Merged

cargo-shuttle: 0.18.0 -> 0.19.0 #238766

merged 1 commit into from
Jun 20, 2023

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented Jun 20, 2023

Diff: shuttle-hq/shuttle@v0.18.0...v0.19.0

Changelog: https://github.com/shuttle-hq/shuttle/releases/tag/v0.19.0

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjni
Copy link
Contributor

tjni commented Jun 20, 2023

Result of nixpkgs-review pr 238766 run on aarch64-darwin 1

1 package built:
  • cargo-shuttle

pkg-config
];

buildInputs = [
curl
libgit2_1_5
openssl
Copy link
Contributor

@tjni tjni Jun 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to this commit, it might be possible to remove openssl.

Ignore this: I see that upstream realized they still need openssl for now in shuttle-hq/shuttle#1023.

@drupol drupol merged commit 4f02b42 into NixOS:master Jun 20, 2023
@figsoda figsoda deleted the shuttle branch June 20, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants