Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some links show..some don't #41

Open
pmasonuh opened this issue Apr 29, 2022 · 2 comments
Open

Some links show..some don't #41

pmasonuh opened this issue Apr 29, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@pmasonuh
Copy link

pmasonuh commented Apr 29, 2022

The following link does work (Any Yahoo Link):
https://www.yahoo.com/sports/the-story-behind-the-famous-brett-favre-draft-day-jorts-photo-004308103.html

The following link does not work:
https://abnb.me/40S5opfYcpb

But, this works:
https://abnb.me

@NickM-27
Copy link
Owner

Thanks, this would be due to the underlying library dependency on jsoup. Unfortunately some websites don't present the image in the usual places so jsoup is unable to parse that. It also seems to sometimes struggle with redirect URLs. I will take a look and see if there are any optimizations to make but I am not too sure there is much I can do here without changing to a different library for this purpose (or potentially using multiple).

@NickM-27 NickM-27 added the bug Something isn't working label Apr 30, 2022
@pmasonuh
Copy link
Author

pmasonuh commented Apr 30, 2022

Thanks for the quick response. Yes please do see if there is anything you can do...I've looked around and your repo was the easiest to implement for Kotlin and looks great. I'm somewhat new to Kotlin, but if there is anything I can do to help let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants