handle pagination - needed for Stieger2021 ds #674
Conversation
|
Hey @Samuel-Boehm, Thank you so much for your PR! We are super happy to receive this one. The issue in the CI is not related to your PR. I will fix in another PR, I am sorry for this unrelated issue. I come back in few hours. |
Samuel-Boehm
force-pushed
the
develop
branch
from
d28fd40 to
a71aaa8
Compare
|
Sorry If I made mistakes here! I am currently working on an implementation of the original BEETL dataset for MOABB and was on the way of finishing it. However, I didn't want it to end up here in the branch. I am kind of new to git and contributing to projects. I will write a new merge request for the BEETL set soon. |
|
Hey @Samuel-Boehm, Thank you so much for the PR! We have been back from vacation since last week, and all the PR will move faster. If you are interested in participating more actively in the moabb discussions and helping to improve the tool and gain citations with new versions, please contact me (b.aristimunha@gmail.com), we are in need of more people for the library. The solution is more straightforward. Could you remove the file from the URL, as reported in #677? Could you update this PR to change only the URL? |
|
Thats a ways simpler solution, I implemented it and its runs, but I did not run any tests for other datasets besides Stieger2021. |
|
Perfect! When everything is green we apply the merge |
When working with the Stieger2021 dataset, I encountered an issue where only the first subject's data was being downloaded. The problem I found was
fs_get_file_listfunctionwasn't properly handling the Figshare API's pagination. With this implementation, the function now retrieves all files across every page of results, ensuring complete data collection for all subjects in the dataset.