refactor(blockifier): get_execution_info v1 and v2 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PearsonWhite
force-pushed
the
pwhite/refactor_get_execution_info
branch
from
c7724a1 to
57981db
Compare
PearsonWhite
commented
Oct 21, 2024
| @@ -253,49 +337,9 @@ impl<'state> StarknetSyscallHandler for &mut NativeSyscallHandler<'state> { | |||
| self.execution_context.gas_costs().get_execution_info_gas_cost, | |||
| )?; | |||
There was a problem hiding this comment.
I think it's fine to keep some duplication between these functions because:
- This "get" functions breaks the Command Query Separation principle with
pre_execute_syscalland hiding it behind anything would make it less immediately noticeable. - Both
get_execution_infofunctions should still have the basic logic of what they're doing directly in their function bodies. - The functions are now both pretty small and straightforward.
PearsonWhite
force-pushed
the
pwhite/refactor_get_execution_info
branch
from
57981db to
f8cddb4
Compare
|
I don't know why the commit linter thinks I have an empty subject and type, but I modeled my commit message after the ones on the Starkware repo. Fixed. It was looking at the PR title. |
PearsonWhite
force-pushed
the
pwhite/refactor_get_execution_info
branch
2 times, most recently
from
45ee597 to
1d10294
Compare
PearsonWhite
changed the title
PearsonWhite
force-pushed
the
pwhite/refactor_get_execution_info
branch
from
1d10294 to
28113df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the block_info and tx_info blocks from
get_execution_infoandget_execution_info_v2to helper functions inimpl<'state> NativeSyscallHandler<'state>to make functions smaller and reduce duplication.block_info = ...was the same for both functions.