Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Provided image source gets unintentionally disposed #10654

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CatchABus
Copy link
Contributor

PR Checklist

What is the current behavior?

Image provided source has its native instance disposed during view disposal even when ImageSource instance is provided by developer.

What is the new behavior?

Image provided source does not have its native instance disposed during view disposal when ImageSource instance is provided by developer.
To avoid this, we wrap the native source inside a new ImageSource instance.

Developers will be responsible for cleaning up the image sources they provide just like it has always been for android.
Also, improved code readability for ImageSource.setNativeSource.

Fixes #9820 (revisited) #10625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NS 8.2.0+ iOS Base64 images disappearing after scrolling ListView/RadListView
1 participant