feat(ios): Added background-image support for iOS action bar #10645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatchABus
changed the title
CatchABus
force-pushed
the
ios-feat-background-image
branch
from
03b2989 to
1516173
Compare
|
is this support for Android too? |
Android should already support gradients by default. |
oh okay |
NathanWalker
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Right now, iOS action bar does not support
background-image.What is the new behavior?
This PR will add support for
background-imageon iOS action bar.Few samples with color, gradient, and image with size contain & repeat are attached below.
Fixes/Implements/Closes #6313 #9338 NativeScript/nativescript-dev-webpack#874.