Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies for v1.2 release #796

Merged
merged 22 commits into from
Sep 30, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Download punkt_tab required by nltk 3.9
  • Loading branch information
juhoinkinen committed Aug 22, 2024
commit 66512f554d8839453a89fdfe81656d7f4b63ddf4
2 changes: 1 addition & 1 deletion .github/workflows/cicd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ jobs:
# download the small English pretrained spaCy model needed by spacy analyzer
poetry run python -m spacy download en_core_web_sm --upgrade-strategy only-if-needed
fi
poetry run python -m nltk.downloader punkt
poetry run python -m nltk.downloader punkt_tab
- name: Test with pytest
run: |
poetry run pytest --cov=./ --cov-report xml
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ RUN echo "Installing dependencies for optional features: $optional_dependencies"
&& rm -rf /root/.cache/pypoetry # No need for cache because of poetry.lock

# Download nltk data
RUN python -m nltk.downloader punkt -d /usr/share/nltk_data
RUN python -m nltk.downloader punkt_tab -d /usr/share/nltk_data

# Download spaCy models, if the optional feature was selected
ARG spacy_models=en_core_web_sm
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ The recommended way is to install Annif from

You will also need NLTK data files:

python -m nltk.downloader punkt
python -m nltk.downloader punkt_tab

Start up the application:

Expand Down Expand Up @@ -115,7 +115,7 @@ Enter the virtual environment:

You will also need NLTK data files:

python -m nltk.downloader punkt
python -m nltk.downloader punkt_tab

Start up the application:

Expand Down
Loading