Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use isort to order import statements #641

Merged
merged 7 commits into from
Nov 8, 2022
Merged

Use isort to order import statements #641

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f5507c6
Add isort to development dependencies
juhoinkinen Nov 7, 2022
920d948
Configure isort to be compatible with Black
juhoinkinen Nov 7, 2022
68a72c5
Reorder import statements with isort
juhoinkinen Nov 7, 2022
e1b52a9
Ignore modifications by isort in git blame
juhoinkinen Nov 7, 2022
fa8e471
Add isort step to linting job in GH Actions
juhoinkinen Nov 7, 2022
9629754
Add how to use isort in Code style section
juhoinkinen Nov 7, 2022
5bdc77f
Fix commit hash for ignoring modifications by isort in git blame
juhoinkinen Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add isort step to linting job in GH Actions
  • Loading branch information
@juhoinkinen
juhoinkinen committed Nov 7, 2022
commit fa8e4712aa63d00b09bf72de29153b94739ab9c9
3 changes: 2 additions & 1 deletion .github/workflows/cicd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,10 @@ jobs:

lint:
runs-on: ubuntu-latest
name: lint with Black
name: lint with isort & Black
steps:
- uses: actions/checkout@v3
- uses: isort/isort-action@f14e57e1d457956c45a19c05a89cccdf087846e5 # v1.1.0
- uses: psf/black@6b42c2b8c9f9bd666120a2c19b8da509fe477f27

test:
Expand Down