Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve sweep and serial controls state #745

Merged

Conversation

redrathnure
Copy link
Contributor

Disable some buttons when device is not connected:

  • disable Serial -> Manage and Sweep -> Start button when device is not connected
  • disable Serial -> Connect button when port was not selected

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • [] Feature
  • [] Code style update (formatting, renaming)
  • [] Refactoring (no functional changes, no API changes)
  • [] Build-related changes
  • [] Documentation content changes
  • [] Other (please describe):

What is the current behavior?

There are two issues:

  • it's possible to click connect button when no ports selected (e.g. no any physical devices connected)
  • it's possible to open serial management OR start sweep when no VNA connected

These crash application.

Issue Number: N/A

What is the new behavior?

Disable connect button when no any physical devices existed.
Disable serial management dialog and sweep start button when no serial was connected.

Does this introduce a breaking change?

  • [] Yes
  • No

Other information

- Disable Serial -> Manage and Sweep-> Start button when device is not connected
- Disable Serial -> Connect button wehn port was not selected
@redrathnure redrathnure requested a review from zarath as a code owner December 31, 2024 21:33
Copy link
Collaborator

@zarath zarath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@zarath zarath merged commit b5da81b into NanoVNA-Saver:main Jan 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants